Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Default Response on Timeout Middleware to ServiceUnavailable #2180

Conversation

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Oct 17, 2018

Seems consistent with recent changes.

@@ -40,5 +40,5 @@ object Timeout {
W: EntityEncoder[G, String]): Kleisli[F, A, Response[G]] =
apply(
timeout,
Response[G](Status.InternalServerError).withEntity("The response timed out.").pure[F])(http)
Response[G](Status.ServiceUnavailable).withEntity("The response timed out.").pure[F])(http)

This comment has been minimized.

@rossabaker

rossabaker Oct 17, 2018
Member

We have a Response.timedOut. Any reason not to use that for consistency?

@rossabaker rossabaker added this to the 0.19.1 milestone Oct 18, 2018
Copy link
Member

@rossabaker rossabaker left a comment

👍 on green

@ChristopherDavenport ChristopherDavenport merged commit 0eab8bd into http4s:master Oct 19, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ChristopherDavenport ChristopherDavenport deleted the ChristopherDavenport:unavailableTimeoutMiddleware branch Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants