Change Default Response on Timeout Middleware to ServiceUnavailable #2180
Conversation
| @@ -40,5 +40,5 @@ object Timeout { | |||
| W: EntityEncoder[G, String]): Kleisli[F, A, Response[G]] = | |||
| apply( | |||
| timeout, | |||
| Response[G](Status.InternalServerError).withEntity("The response timed out.").pure[F])(http) | |||
| Response[G](Status.ServiceUnavailable).withEntity("The response timed out.").pure[F])(http) | |||
rossabaker
Oct 17, 2018
Member
We have a Response.timedOut. Any reason not to use that for consistency?
We have a Response.timedOut. Any reason not to use that for consistency?
|
|
ChristopherDavenport
deleted the
ChristopherDavenport:unavailableTimeoutMiddleware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Seems consistent with recent changes.