Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
ChristopherDavenport
added some commits
Oct 17, 2018
| @@ -40,5 +40,5 @@ object Timeout { | ||
| W: EntityEncoder[G, String]): Kleisli[F, A, Response[G]] = | ||
| apply( | ||
| timeout, | ||
| Response[G](Status.InternalServerError).withEntity("The response timed out.").pure[F])(http) | ||
| Response[G](Status.ServiceUnavailable).withEntity("The response timed out.").pure[F])(http) |
This comment has been minimized.
This comment has been minimized.
rossabaker
Oct 17, 2018
Member
We have a Response.timedOut. Any reason not to use that for consistency?
rossabaker
added this to the 0.19.1 milestone
Oct 18, 2018
ChristopherDavenport
merged commit 0eab8bd
into
http4s:master
Oct 19, 2018
ChristopherDavenport
deleted the
ChristopherDavenport:unavailableTimeoutMiddleware
branch
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ChristopherDavenport commentedOct 17, 2018
Seems consistent with recent changes.