Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request and response concurrent in blaze-client #2184

merged 1 commit into from Oct 19, 2018


Copy link

@rossabaker rossabaker commented Oct 18, 2018

Start receiving the response concurrently with rendering the request. Many responses can be generated without consuming the body in its entirety, so there's no need to finish the write before trying to read.

@rossabaker rossabaker requested a review from ChristopherDavenport Oct 18, 2018
val server =
new InetSocketAddress(hostname, 0),
maxQueued = 10,

This comment has been minimized.


rossabaker Oct 18, 2018
Author Member

I don't see where this parameter is used in the fs2 code.

@rossabaker rossabaker force-pushed the rossabaker:blaze-client-buffering branch from 3e335c3 to 7a8257f Oct 19, 2018
@rossabaker rossabaker added this to the 0.19.1 milestone Oct 19, 2018
@rossabaker rossabaker changed the title Write request concurrently with reading response in blaze-client Request and response concurrent in blaze-client Oct 19, 2018
Copy link
Member Author

@rossabaker rossabaker commented Oct 19, 2018

@lbialy: This will allow the blaze-client to process a response before sending the entire request, and #2190 will give you greater control over how much is buffered before the server reads it via withSocketSendBufferSize.

@rossabaker rossabaker merged commit 4b61be6 into http4s:master Oct 19, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@rossabaker rossabaker deleted the rossabaker:blaze-client-buffering branch Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants