Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
rossabaker
requested a review
from
ChristopherDavenport
Oct 18, 2018
| val server = | ||
| serverWithLocalAddress[IO]( | ||
| new InetSocketAddress(hostname, 0), | ||
| maxQueued = 10, |
This comment has been minimized.
This comment has been minimized.
rossabaker
force-pushed the
rossabaker:blaze-client-buffering
branch
from
3e335c3
to
7a8257f
Oct 19, 2018
rossabaker
added this to the 0.19.1 milestone
Oct 19, 2018
rossabaker
changed the title from
Write request concurrently with reading response in blaze-client
to
Request and response concurrent in blaze-client
Oct 19, 2018
This comment has been minimized.
This comment has been minimized.
rossabaker
merged commit 4b61be6
into
http4s:master
Oct 19, 2018
rossabaker
deleted the
rossabaker:blaze-client-buffering
branch
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rossabaker commentedOct 18, 2018
•
edited
Start receiving the response concurrently with rendering the request. Many responses can be generated without consuming the body in its entirety, so there's no need to finish the write before trying to read.