Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting socket options on blaze-client #2190

Merged
merged 1 commit into from Oct 19, 2018

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Oct 19, 2018

No description provided.

@rossabaker rossabaker added this to the 0.19.1 milestone Oct 19, 2018
@@ -128,10 +133,58 @@ sealed abstract class BlazeClientBuilder[F[_]] private (
def withoutAsynchronousChannelGroup: BlazeClientBuilder[F] =
withAsynchronousChannelGroupOption(None)

def channelOption[A](socketOption: SocketOption[A]) =
Copy link
Member Author

@rossabaker rossabaker Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic should probably move to blaze itself.

def withDefaultChannelOption[A](key: SocketOption[A]): BlazeClientBuilder[F] =
withChannelOptions(ChannelOptions(channelOptions.options.filterNot(_.key == key)))

def socketSendBufferSize: Option[Int] =
Copy link
Member Author

@rossabaker rossabaker Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the options that are allowed on an AsynchronousSocketChannel and are provided as a convenience so people don't need to think about existential types.

@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Oct 19, 2018

Build failure is #2191.

@rossabaker rossabaker merged commit 54a2c12 into http4s:master Oct 19, 2018
1 of 2 checks passed
@rossabaker rossabaker deleted the blaze-client-socket-options branch Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants