New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shut down a jetty server gracefully #2222

Merged
merged 2 commits into from Oct 31, 2018

Conversation

Projects
None yet
2 participants
@rossabaker
Member

rossabaker commented Oct 30, 2018

Adds a shutdownTimeout to the server builder.

  • When the resource is closed, we call jetty.stop().
  • Add a lifecycle listener to await the stop.
    • If the server stops within the shutdownTimeout, complete the release.
    • If not, jetty force stops and we fail the release with a TimeoutException

@rossabaker rossabaker force-pushed the rossabaker:graceful-jetty-server-shutdown branch from 671b8f4 to d2cca12 Oct 30, 2018

@rossabaker rossabaker added this to the 0.20.0 milestone Oct 30, 2018

@ChristopherDavenport

This comment has been minimized.

Member

ChristopherDavenport commented Oct 30, 2018

Procedure syntax issues on 2.11

@ChristopherDavenport

👍 on green

@rossabaker rossabaker merged commit f9156f0 into http4s:master Oct 31, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rossabaker rossabaker deleted the rossabaker:graceful-jetty-server-shutdown branch Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment