Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shut down a jetty server gracefully #2222

Merged
merged 2 commits into from Oct 31, 2018
Merged

Shut down a jetty server gracefully #2222

merged 2 commits into from Oct 31, 2018

Conversation

rossabaker
Copy link
Member

Adds a shutdownTimeout to the server builder.

  • When the resource is closed, we call jetty.stop().
  • Add a lifecycle listener to await the stop.
    • If the server stops within the shutdownTimeout, complete the release.
    • If not, jetty force stops and we fail the release with a TimeoutException

@rossabaker rossabaker added the enhancement Feature requests and improvements label Oct 30, 2018
@rossabaker rossabaker force-pushed the graceful-jetty-server-shutdown branch from 671b8f4 to d2cca12 Compare October 30, 2018 03:06
@rossabaker rossabaker added this to the 0.20.0 milestone Oct 30, 2018
This was referenced Oct 30, 2018
Open
Merged
@ChristopherDavenport
Copy link
Member

Procedure syntax issues on 2.11

ChristopherDavenport
ChristopherDavenport approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on green

@rossabaker rossabaker merged commit f9156f0 into http4s:master Oct 31, 2018
@rossabaker rossabaker deleted the graceful-jetty-server-shutdown branch October 31, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

Assignees
No one assigned
Labels
enhancement Feature requests and improvements
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rossabaker @ChristopherDavenport