New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in changelog 0.19.0-M3: swapped Resource and Response #2226

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
2 participants
@lunedis
Contributor

lunedis commented Oct 30, 2018

Hi,

in the changelog for v0.19.0-M3 it says:

#2102: Refactoring of Client and some builders:
Client is no longer a case class. Construct a new Client backend or middleware with Client.apply(run: Request[F] => Response[F, Resource[F]]) for any F with a Bracket[Throwable, F].

One line below, in the linked issue and in the source code it says:

Request[F] => Resource[F, Response[F]]

This PR fixes this typo in changelog.md.

@rossabaker

Good catch. Thanks!

@rossabaker rossabaker merged commit 85618c3 into http4s:master Oct 30, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@lunedis lunedis deleted the lunedis:changelog_client_refactor_typo_fix branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment