New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one error in maxWaitQueueLimit #2231

Merged
merged 2 commits into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@rossabaker
Member

rossabaker commented Nov 1, 2018

We're not counting ourselves against the maxWaitQueueLimit when enqueuing a waiter, which results in us going one past the maxWaitQueueLimit.

@rossabaker rossabaker added the bug label Nov 1, 2018

@rossabaker rossabaker added this to the 0.18.21 milestone Nov 1, 2018

@aeons

This comment has been minimized.

Member

aeons commented Nov 1, 2018

So, 'procedure syntax' actually means 'trailing commas' in this case :)

@rossabaker

This comment has been minimized.

Member

rossabaker commented Nov 1, 2018

I wish there were a Scala 2.11 plugin to support trailing commas. I accidentally leave them all over the place, and actually like them for diff reduction. Thanks for the fix!

@aeons aeons merged commit 27ac330 into http4s:release-0.18.x Nov 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rossabaker rossabaker deleted the rossabaker:maxWaitQueueLimit branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment