New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cookie string to have ';' at the end #2237

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
4 participants
@bhop
Contributor

bhop commented Nov 2, 2018

fixes: #2206

@aeons

aeons approved these changes Nov 2, 2018

@rossabaker

This could be backported to 0.18.x, if there's demand. I've already got one bugfix ready to go there.

@rossabaker

This comment has been minimized.

Member

rossabaker commented Nov 2, 2018

This is more of an enhancement than a bugfix, and 0.18.x is on its last legs. If someone wants it, we can merge a backport PR. Until then, I'm merging as-is.

@rossabaker rossabaker merged commit 76c5e54 into http4s:master Nov 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bhop bhop deleted the bhop:parse-cookie-semicolon-at-the-end branch Nov 2, 2018

@balatbn

This comment has been minimized.

balatbn commented Nov 2, 2018

Thanks for the fix. We have temporarily "fixed" the original issue(2206) by removing ";" in our code.

We can wait until next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment