New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add the idle timeout stage when idleTimeout is finite #2241

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@rossabaker
Member

rossabaker commented Nov 5, 2018

When debug logging is on, an infinite idleTimeout crashes, and an infinite idle timeout is useless anyway.

@rossabaker rossabaker added the bug label Nov 5, 2018

@rossabaker rossabaker added this to the 0.20.0 milestone Nov 5, 2018

@rossabaker rossabaker merged commit 8cdcc4d into http4s:master Nov 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rossabaker rossabaker deleted the rossabaker:finite-idle-timeout-stage branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment