New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or privatize server builder *support traits #2243

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@rossabaker
Member

rossabaker commented Nov 5, 2018

The server builder traits were a poor means of abstraction that few were using in the wild anyway.

  • Eliminate marker traits for server builders
  • Privatize ServerBuilder, which does still contribute to consistency
  • Move defaults into org.http4s.server.defaults package
@rossabaker

This comment has been minimized.

Member

rossabaker commented Nov 5, 2018

Build failure is #2197.

@aeons

aeons approved these changes Nov 5, 2018

@rossabaker rossabaker merged commit f8866d0 into http4s:master Nov 5, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rossabaker rossabaker deleted the rossabaker:server-builder-trait-cleanup branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment