Fix deadlocks on failures with parTraverse and parSequence #2258
Conversation
@rossabaker should this be reopened? |
Yes, I mentioned it in the other ticket and it autoclosed. |
_ <- failedRequests.handleErrorWith(_ => IO.unit) | ||
_ <- failedRequests.handleErrorWith(_ => IO.unit) | ||
_ <- failedRequests.handleErrorWith(_ => IO.unit) | ||
_ <- failedRequests.handleErrorWith(_ => IO.unit) | ||
_ <- failedRequests.handleErrorWith(_ => IO.unit) |
ngbinh
Nov 11, 2018
Author
Contributor
I remember there are cases where we need to flatmap
two failures to reproduce the error.
I remember there are cases where we need to flatmap
two failures to reproduce the error.
rossabaker
Nov 11, 2018
Member
Travis is a bit underpowered, so hitting it too hard can lead to spurious failures, so we'll have to find the right balance here. I'll bump it back up, and we'll see if we can turn it back down.
It passed, when it fails most of the time for me locally on #2265. Some bugs are exposed only by slow Travis and some bugs are hidden by slow Travis. 😩
Travis is a bit underpowered, so hitting it too hard can lead to spurious failures, so we'll have to find the right balance here. I'll bump it back up, and we'll see if we can turn it back down.
It passed, when it fails most of the time for me locally on #2265. Some bugs are exposed only by slow Travis and some bugs are hidden by slow Travis.
The last commit should also fix #2265. |
looks great to me. Thanks! |
This was referenced Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Both of these tests fail by timing out on my local machine: