New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change UrlForm to use Chain instead of Seq #2262

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@bpholt
Contributor

bpholt commented Nov 10, 2018

Chain has a Monoid instance available to it, while Seq does not. Partially addresses #2096.

This was a pretty mechanical conversion and might be able to be optimized.

change UrlForm to use Chain instead of Seq
Chain has a Monoid instance available to it, while Seq does not.
Partially addresses #2096.

@bpholt bpholt force-pushed the Dwolla:urlform-chain branch from 8fa24b1 to a469bd9 Nov 10, 2018

def get(key: String): Seq[String] =
this.getOrElse(key, Seq.empty[String])
def get(key: String): Chain[String] =
this.getOrElse(key, Chain.empty[String])

This comment has been minimized.

@ChristopherDavenport

ChristopherDavenport Nov 13, 2018

Member

I have zero clue how this works calling this rather than values

This comment has been minimized.

@rossabaker

rossabaker Nov 13, 2018

Member

Line 18

This comment has been minimized.

@ChristopherDavenport

ChristopherDavenport Nov 13, 2018

Member

Thank you, I feel more sane now.

@rossabaker rossabaker merged commit 75f9257 into http4s:master Nov 13, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment