Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client dsl with body first #2269

Merged
merged 5 commits into from Nov 13, 2018

Conversation

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Nov 13, 2018

Builds on #2202

Copy link
Member

@rossabaker rossabaker left a comment

I don't see another way out.

Ideally we'd add a scalafix here. Would you like to bolt it on here or should we put out a call for help?

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Nov 13, 2018

Call out for help, I have zero scalafix knowledge still.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Nov 13, 2018

I want to get this feature in place and I want to release. Should we merge now and have a scalafix to follow?

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Nov 13, 2018

I think that seems the best idea. Help out migration as soon as we can, get the baseline code in place first.

@rossabaker rossabaker merged commit 8b415f5 into http4s:master Nov 13, 2018
1 check passed
@ChristopherDavenport ChristopherDavenport deleted the clientDslWithBodyFirst branch Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants