New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scalafix github based #2276

Merged
merged 9 commits into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@amarrella
Contributor

amarrella commented Nov 14, 2018

Fixes #2274

amarrella added some commits Nov 14, 2018

@amarrella

This comment has been minimized.

Contributor

amarrella commented Nov 14, 2018

If you want to test it, just run:

sbt ";scalafixEnable; scalafix github:amarrella/http4s/v0_20?sha=scalafix-gh"

amarrella added some commits Nov 14, 2018

@amarrella

This comment has been minimized.

Contributor

amarrella commented Nov 14, 2018

@rossabaker this is done. I just moved the code around :) It's not beautiful as it's all in one file but it doesn't need to be. It's much easier to use now from a user's (and scala-steward :D ) perspective

@rossabaker rossabaker added this to the 0.20.0 milestone Nov 15, 2018

@rossabaker

This comment has been minimized.

Member

rossabaker commented Nov 15, 2018

A ramification of this is that it's no longer tested by Travis, right?

Adding to 0.20 milestone since it affects what we publish. I don't like removing published artifacts in the middle of a series.

@amarrella

This comment has been minimized.

Contributor

amarrella commented Nov 15, 2018

A ramification of this is that it's no longer tested by Travis, right?

I guess we could add a line to the script in .travis.yml if that's what we want? I'm not sure how we specify the different build.sbt, maybe we can trick travis via cd

@amarrella

This comment has been minimized.

Contributor

amarrella commented Nov 15, 2018

Adding to 0.20 milestone since it affects what we publish. I don't like removing published artifacts in the middle of a series.

Fair enough, we could also leave the binary and publish both actually. We just need to point the projects in the main build sbt to the subdirectory. This would solve the travis problem too

@rossabaker

This comment has been minimized.

Member

rossabaker commented Nov 15, 2018

If we want it to have CI, without polluting the main build or Maven Central, we could also add an environment variable to the build matrix. And then the script would be cd $ROOT_DIR && sbt ++$TRAVIS_SCALA_VERSION ci. We'd lose sbt ci from the top-level running all the tests, but very few contributors (including me) are vigilant about doing that.

If running scalafix through CI is not typical, I'd accept that, too. I'm commenting on developer instinct, not scalafix experience. I'm going to be highly deferential here.

@amarrella

This comment has been minimized.

Contributor

amarrella commented Nov 15, 2018

If running scalafix through CI is not typical, I'd accept that, too. I'm commenting on developer instinct, not scalafix experience. I'm going to be highly deferential here.

I think having ci is a good idea if possible. Though it doesn't look that e.g. cats have any ci for that.
Your call :)

@rossabaker

This comment has been minimized.

Member

rossabaker commented Nov 15, 2018

Let's keep CI one way or another. I hate to see bitrot.

amarrella added some commits Nov 15, 2018

@amarrella

This comment has been minimized.

Contributor

amarrella commented Nov 15, 2018

Went the matrix route. I think it's the cleanest

@rossabaker rossabaker merged commit 30f88e7 into http4s:master Nov 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment