Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #2280 `org.http4s.util.decode` throws `ClassCastException` on empty chunk #2281

Merged
merged 2 commits into from Nov 28, 2018

Conversation

@zarthross
Copy link
Member

@zarthross zarthross commented Nov 16, 2018

This should fix issue #2280

@zarthross
Copy link
Member Author

@zarthross zarthross commented Nov 16, 2018

Based on the fact that 6d4ca08 's build passed, and I'm running Java9 locally, it appears this was a Java9 specific bug.

@zarthross
Copy link
Member Author

@zarthross zarthross commented Nov 16, 2018

Looks like the JDK11 build did actually fail on 6d4ca08 but passed on 9f92e33

@rossabaker rossabaker added the bug label Nov 16, 2018
@rossabaker rossabaker added this to the 0.20.0 milestone Nov 16, 2018
Copy link
Member

@rossabaker rossabaker left a comment

I wonder if this bug dates back to when empty chunks were elided. In any case, 👍. It's the right thing to do now. Thanks!

@aeons aeons merged commit dedb2ee into http4s:master Nov 28, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zarthross zarthross deleted the zarthross:issue-2280-util-decode-empty-chunk branch Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.