Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate BlazeServer companion, forward to BlazeServerBuilder #2285

Merged
merged 2 commits into from Nov 19, 2018

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Nov 17, 2018

We deprecated BlazeBuilder without deprecating its companion. It used the old QuietTimeoutStage, which was broken by other changes.

Now the companion is also deprecated, so people are warned not to use it, and the deprecated implementation now forwards to the maintained version.

Fixes the redux of #2253.

@rossabaker rossabaker force-pushed the rossabaker:blaze-server-deprecation branch from 6e77b2f to 559f510 Nov 17, 2018
@aeons
aeons approved these changes Nov 19, 2018
@aeons aeons merged commit b426719 into http4s:master Nov 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rossabaker rossabaker deleted the rossabaker:blaze-server-deprecation branch Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants