Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalafix: enhancements #2286

Merged
merged 4 commits into from Nov 28, 2018
Merged

Scalafix: enhancements #2286

merged 4 commits into from Nov 28, 2018

Conversation

@amarrella
Copy link
Contributor

@amarrella amarrella commented Nov 17, 2018

  • Fixes #2279 and now the fix is more robust due to the fact that we match to http4s symbols
  • Adds BlazeServerBuilder fix (#2285)
  • Refactors fixes from unapply to apply (internal)
  • Fixes MessageSyntax withBody
  • Instead of renaming the ResponseCookie to cookie in the import, renames it everywhere so it's clearer in the code
@amarrella amarrella changed the title Scalafix: Fixed nested withBody -> withEntity issue WIP Scalafix: enhancements Nov 17, 2018
@amarrella amarrella changed the title WIP Scalafix: enhancements Scalafix: enhancements Nov 17, 2018
Copy link
Member

@rossabaker rossabaker left a comment

I think this will be fine even before #2285.

@amarrella
Copy link
Contributor Author

@amarrella amarrella commented Nov 17, 2018

Yeah right, go for it then :)

@aeons aeons merged commit 5b9b5af into http4s:master Nov 28, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants