Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown in BlazeClientBuilder #2305

Merged
merged 1 commit into from Dec 5, 2018
Merged

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Dec 5, 2018

We were throwing away the F[Unit] instead of returning it.

Bonus: removed parens on shutdown(), since it's a pure value, not a side effect.

@rossabaker rossabaker added the bug label Dec 5, 2018
@rossabaker rossabaker added this to the 0.20.0 milestone Dec 5, 2018
Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Whoops!

@rossabaker rossabaker merged commit 15864ac into master Dec 5, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rossabaker rossabaker deleted the fix-blaze-client-shutdown branch Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.