New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal allocated in favor of cats-effect-1.1's #2308

Merged
merged 3 commits into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@rossabaker
Copy link
Member

rossabaker commented Dec 5, 2018

No description provided.

@@ -17,6 +17,9 @@ private[http4s] trait BackendBuilder[F[_], A] {
*/
def stream: Stream[F, A] = Stream.resource(resource)

@deprecated("Use allocated instead", "0.20.0-RC1")

This comment has been minimized.

@ChristopherDavenport

ChristopherDavenport Dec 6, 2018

Member

We're giving a deprecation cycle for milestone code?

This comment has been minimized.

@rossabaker

rossabaker Dec 6, 2018

Author Member

I'm not 100% sure it's new, but fair.

Well, I guess it has to be new, because there was no Resource in 0.18. Okay.

@rossabaker rossabaker merged commit b8fa708 into http4s:master Dec 6, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@rossabaker rossabaker deleted the rossabaker:use-cats-effect-allocate branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment