Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change clientAuthMode to an enum #2351

Merged
merged 4 commits into from Jan 13, 2019
Merged

Conversation

@balatbn
Copy link

@balatbn balatbn commented Jan 11, 2019

With this mTLS can be optional for the request.

Changes as per discussion on #2218.

Note that this is a breaking change. Existing boolean value is changed to an enum.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jan 11, 2019

Test failure is #2352.

Copy link
Member

@rossabaker rossabaker left a comment

Thanks! I like the spirit of the change. Just a couple details I'm not sure on.

Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

This seems like a good idea to me, if someone was using this its breaking, but using the defaults it is not.

@rossabaker rossabaker mentioned this pull request Jan 11, 2019
Copy link
Member

@rossabaker rossabaker left a comment

I don't have time to go over the tests before I head out for a few hours, but the main code looks right to me. If someone else approves, it has my blessing and we can release.

If not, I'll take a more thorough pass tonight.

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 11, 2019

New test appeared to fail on 2.12 build. Retrying, but worrisome.

@balatbn
Copy link
Author

@balatbn balatbn commented Jan 11, 2019

In my local machine, I get a "Connection reset" error message if mTLS fails. In CI box, it is giving a "Remote host closed connection during handshake" message.

@rossabaker rossabaker merged commit 1407121 into http4s:master Jan 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@balatbn balatbn deleted the balatbn:clientAuthMode branch Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants