Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add HttpMethodOverrider middleware #2355
This one adds an Http Method Overrider middleware(to contribute with #2014) in order to allow using HTTP verbs such as PUT or DELETE in places where the client doesn't support it.
Let me know what you guys think of it and if it requires some changes, specially in the test description since I'm new with the predominant testing style.
PS: Also, I just realized of the existence of the
Hey @rossabaker, this one is ready for the second round.
In the last commit, I added a third strategy for allowing method override in request receiving an
Also, since I had to generalize for
I got to say it, it kinda looks odd to me -- I'm not an expert whatsoever -- but, the alternative would be to provide the natural transformation when constructing the midleware. I think that'd be unfair for those just want to user Header strategy. Please take a look at let me know your thoughts, especially about the use of
PS: After refactoring a little bit the suggestion of using
Yeah, I have a possible approach for how to improve this, but I don't want to shove this off onto you if you don't want to take it on.
My first idea is that we can put the type parameters all the way up that coproduct hierarchy such that.
@ChristopherDavenport No worries, I can explore that path, especially because that issue was really annoying for me. However, at first glance, I don't see how we can get rid of the type erasure warning when pattern matching on something like