Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Coverage Steps #2359

Merged

Conversation

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 16, 2019

Couldn't find where the plugin was introduced as a dependency. Removed the calls in CI that should have triggered it.

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Jan 17, 2019

Rig defaults appear to be at play at it continuing to run ever after removing all settings.

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Jan 17, 2019

Finally figured out the sbt setting override.

Copy link
Member

@rossabaker rossabaker left a comment

I think rig is past its prime, but ripping that out will require replacing the release automation. This is a good first step.

@ChristopherDavenport ChristopherDavenport merged commit 4d49f95 into http4s:master Jan 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ChristopherDavenport ChristopherDavenport deleted the removeCodeCoverage branch Jan 17, 2019
@jgogstad
Copy link
Contributor

@jgogstad jgogstad commented Sep 3, 2020

I'm looking at introducing test coverage to my team. Out of curiosity, why did you remove it from http4s?

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Oct 14, 2020

  1. Few people, if any, looked at the data.
  2. The data is noisy, particularly with property tests, which introduce non-determinism.
  3. If you're not careful about your build, it's easy to release instrumented code.

All that said, if taken as a reference and not as a management edict, I think coverage can still provide value. Just beware Goodhart's Law.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants