Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bufferMaxSize parameter of CachingChunkWriter made configurable #2366

Merged
merged 9 commits into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@augi
Copy link
Contributor

augi commented Jan 21, 2019

Also the default value changed from 10 * 1024 to 1024 * 1024. Fixes #2363

@rossabaker
Copy link
Member

rossabaker left a comment

Thanks!

I don't think the test failure is your fault, but I haven't seen that one before as one of the intermittent ones. Curious to see what happens when we apply those tweaks.

@augi

This comment has been minimized.

Copy link
Contributor Author

augi commented Jan 22, 2019

Thank you for the comments! I fixed both issues.

@rossabaker

This comment has been minimized.

Copy link
Member

rossabaker commented Jan 24, 2019

Thanks! We seem to have persistently broken this test. I suspect it might be related to this change. I think we're good after that.

@augi

This comment has been minimized.

Copy link
Contributor Author

augi commented Jan 24, 2019

Thank you for pointing me to this test!

In TravisCI, it failed after 5 seconds (timeout) but it finishes successfully in 3 seconds on my machine. So I decided to use smaller chunkBufferMaxSize for this test suite.

After this change, this test finishes under one second on my machine so the 5 seconds will be hopefully suficient for TravisCI.

@augi

This comment has been minimized.

Copy link
Contributor Author

augi commented Jan 24, 2019

There was similar issue with blaze-server tests so I've fixed it as well.

@rossabaker
Copy link
Member

rossabaker left a comment

Thanks!

@ChristopherDavenport ChristopherDavenport merged commit 4807a6d into http4s:master Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.