Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger purification #2369

Merged

Conversation

Projects
None yet
2 participants
@ChristopherDavenport
Copy link
Member

ChristopherDavenport commented Jan 22, 2019

Fixes #2368

@rossabaker
Copy link
Member

rossabaker left a comment

Agree with the change, nervous about one detail.

}
)
}
}
.handleErrorWith(t =>
F.delay(logger.info(s"service raised an error: ${t.getClass}")) *> F
F.delay(log(s"service raised an error: ${t.getClass}")) *> F

This comment has been minimized.

Copy link
@rossabaker

rossabaker Jan 24, 2019

Member

Getting sleepy but isn't this delaying an F and discarding it?

This comment has been minimized.

Copy link
@ChristopherDavenport
@rossabaker
Copy link
Member

rossabaker left a comment

👍 after scalafmt

@ChristopherDavenport ChristopherDavenport merged commit 7d5b42d into http4s:master Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ChristopherDavenport ChristopherDavenport deleted the ChristopherDavenport:loggerPurification branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.