Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger purification #2369

Merged

Conversation

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 22, 2019

Fixes #2368

Copy link
Member

@rossabaker rossabaker left a comment

Agree with the change, nervous about one detail.

}
)
}
}
.handleErrorWith(t =>
F.delay(logger.info(s"service raised an error: ${t.getClass}")) *> F
F.delay(log(s"service raised an error: ${t.getClass}")) *> F
Copy link
Member

@rossabaker rossabaker Jan 24, 2019

Getting sleepy but isn't this delaying an F and discarding it?

Copy link
Member Author

@ChristopherDavenport ChristopherDavenport Jan 24, 2019

Yes.

Copy link
Member

@rossabaker rossabaker left a comment

👍 after scalafmt

@ChristopherDavenport ChristopherDavenport merged commit 7d5b42d into http4s:master Jan 31, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ChristopherDavenport ChristopherDavenport deleted the loggerPurification branch Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants