Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include scheme in CORS middleware examples #2374

Merged
merged 1 commit into from Jan 31, 2019

Conversation

@CloudNiner
Copy link
Contributor

@CloudNiner CloudNiner commented Jan 25, 2019

Clarifies CORS documentation based on a comment in

#2361 (comment)

According to MDN
the scheme is a required part of the header so a change in the underlying header
parser to reflect this makes sense.

Connects #2361

Clarifies CORS documentation based on a comment in

http4s#2361 (comment)

It remains unclear to me if this is a bug or desired change in behavior
so I made no further attempts to modify source or test code.
@ChristopherDavenport ChristopherDavenport merged commit 2e8f94e into http4s:master Jan 31, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants