Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Request Key #2389

Merged

Conversation

@kevinmeredith
Copy link
Contributor

@kevinmeredith kevinmeredith commented Feb 6, 2019

Recently I ran into this message:

No connections available for the desired key. Stats: ...

I wasn't sure which downstream service call was not being serviced, i.e. per the above message.

It seems useful to me to add this value to know this information, i.e. which downstream's call is not being serviced.

@ChristopherDavenport ChristopherDavenport merged commit bcce4bb into http4s:release-0.18.x Feb 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinmeredith kevinmeredith deleted the log-request-key branch Feb 6, 2019
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Feb 6, 2019

I didn't notice this was against 0.18. I guess we could do an 0.18.22?

@kevinmeredith
Copy link
Contributor Author

@kevinmeredith kevinmeredith commented Feb 6, 2019

I guess we could do an 0.18.22?

Yes, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants