Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authorization header in allowed headers #2391

merged 1 commit into from Feb 16, 2019


Copy link

@eklavya eklavya commented Feb 7, 2019

Firefox doesn't allow * in allowed headers for a cors request. Bugzilla

Authorization is a pretty common header and it would make sense to have it in the default set.
I was recently bitten by this.

Copy link

@ChristopherDavenport ChristopherDavenport left a comment

I think this is correct, but would appreciate more familiar eyes.

@rossabaker rossabaker merged commit 884e993 into http4s:master Feb 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants