Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rig Plugin #2401

Merged
merged 3 commits into from Feb 12, 2019
Merged

Conversation

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Feb 11, 2019

No description provided.

openSonatypeRepo.when(publishable && release),
publishToSonatypeWithoutInstrumentation.when(publishable),
releaseAndClose.when(publishable && release),
releaseStepCommandAndRemaining("+publishSigned").when(publishable),
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport Feb 11, 2019

Any reason not to sign snapshots?

Copy link
Member

@rossabaker rossabaker Feb 12, 2019

I don't see why not.

publishToSonatypeWithoutInstrumentation.when(publishable),
releaseAndClose.when(publishable && release),
releaseStepCommandAndRemaining("+publishSigned").when(publishable),
releaseStepCommand("sonatypeReleaseAll").when(publishable && release),
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport Feb 11, 2019

Introduces slight race conditions across repositories. I've never run into it in practice though.


override lazy val buildSettings = Seq(
// Many steps only run on one build. We distinguish the primary build from
// secondary builds by the Travis build number.
isTravisBuild := sys.env.get("TRAVIS").isDefined,
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport Feb 11, 2019

We used this, so we introduce it.

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Feb 11, 2019

We don't really need a CentralRequirementsPlugin rather than an integrated set of settings anymore. but I also can just depend on it, so I'm not sure its a problem to leave it like that even without rig

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Feb 11, 2019

Should unblock as now we can depend on plugins that can interact with scala 2.13.0-M5 directly.

Copy link
Member

@rossabaker rossabaker left a comment

Brace for impact, because all build changes usually cause pain, but it looks right.

publishArtifact in (Compile, packageDoc) := false,
publishArtifact in (Compile, packageSrc) := false,
publishArtifact := false
) ++ Seq(
Copy link
Member

@rossabaker rossabaker Feb 12, 2019

Is skip in publish := true sufficient in modern sbt?

Copy link
Member Author

@ChristopherDavenport ChristopherDavenport Feb 12, 2019

I can port in my personal anti publishing subset as well.

Copy link
Member

@aeons aeons Feb 12, 2019

Should these use the newer slash-syntax instead? I like that a lot better.

Ie. packageSrc / Compile / publishArtifact := false

Copy link
Member Author

@ChristopherDavenport ChristopherDavenport Feb 12, 2019

I could not get this to work, we can adopt it in a future iteration if you can get it running. 😄

Copy link
Member

@aeons aeons left a comment

Noice. Left one comment.

aeons
aeons approved these changes Feb 12, 2019
Copy link
Member

@aeons aeons left a comment

Last comment was supposed to be an approval.

@ChristopherDavenport ChristopherDavenport merged commit e0c79f1 into http4s:master Feb 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ChristopherDavenport ChristopherDavenport deleted the removeRig branch Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants