Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure AHC to Use NoOp CookieStore by Default #2414

Merged

Conversation

Projects
None yet
2 participants
@ChristopherDavenport
Copy link
Member

ChristopherDavenport commented Feb 13, 2019

Fixes #2413

@@ -145,4 +149,12 @@ object AsyncHttpClient {
Headers(headers.asScala.map { header =>
Header(header.getKey, header.getValue)
}.toList)
private class NoOpCookieStore extends CookieStore {
val empty: java.util.List[Cookie] = new java.util.ArrayList()

This comment has been minimized.

Copy link
@rossabaker

rossabaker Feb 13, 2019

Member

For what it's worth, Java's constant is called Collections.EMPTY_LIST.

@ChristopherDavenport ChristopherDavenport merged commit 2745bc2 into http4s:master Feb 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ChristopherDavenport ChristopherDavenport deleted the ChristopherDavenport:noOpCookieStore branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.