Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include chunked Transfer-Encoding header in multipart requests #2424



Copy link

@rhyskeepence rhyskeepence commented Feb 17, 2019

I discovered that the clients would not send the body of a multipart request, nor do any request logging. Fundamentally, this turned out to be related to issue #2348, where these clients do not send the body of a request unless Transfer-Encoding or Content-Length headers have been set, however this fix just adds the request header for multipart.

Copy link

@rossabaker rossabaker left a comment

It seems to me that a Part could have an optional length, and if the length is known for all parts, we could calculate the length of the request and avoid chunked transfer encoding. But this looks like it improves the current situation.

@ChristopherDavenport ChristopherDavenport merged commit 2713bc9 into http4s:master Feb 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants