Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible dsl #2446

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@hamnis
Copy link
Contributor

hamnis commented Mar 7, 2019

Add new type constructor to be able to construct this DSL for http4s-directives.

trait DirectivesDsl[F[_]] extends Http4sDsl2[Directive[F, ?], F]

object DirectivesDsl {
  def apply[F[_]]: DirectivesDsl[F] = new DirectivesDsl[F] {}
}


object io extends DirectivesDsl[IO]
@hamnis

This comment has been minimized.

Copy link
Contributor Author

hamnis commented Mar 7, 2019

I do not think that the travis build failure is related to this.

@rossabaker
Copy link
Member

rossabaker left a comment

The build failure is because test:scalafmt needs to be run. Otherwise, it looks good to me. Thanks!

Add new type constructor to enable to use the dsl for http4s-directives
o introduce Http4sDsl2 to avoid compatibility issues

@hamnis hamnis force-pushed the hamnis:extensible-dsl branch from 4b69e79 to 00cd51e Mar 9, 2019

@hamnis

This comment has been minimized.

Copy link
Contributor Author

hamnis commented Mar 9, 2019

@rossabaker fixed. thanks for letting me know what the problem was.

@rossabaker
Copy link
Member

rossabaker left a comment

The new test failure is one of the intermittent ones. This looks good to me.

@ChristopherDavenport ChristopherDavenport merged commit 9394fd5 into http4s:master Mar 11, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@hamnis hamnis deleted the hamnis:extensible-dsl branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.