Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CirceInstances.builder initialization #2450

Conversation

@nigredo-tori
Copy link
Contributor

@nigredo-tori nigredo-tori commented Mar 15, 2019

CirceInstancesBuilder is using two vals in CirceInstances as default arguments, but is instantiated (as builder) before those vals are initialized.

Copy link
Member

@rossabaker rossabaker left a comment

Thanks!

@ChristopherDavenport ChristopherDavenport merged commit 9523ba0 into http4s:master Mar 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nigredo-tori nigredo-tori deleted the fix-circe-instances-builder-initialization branch Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants