Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to G type on HttpApp #2455

Merged
merged 1 commit into from Mar 18, 2019
Merged

Conversation

@cquiroz
Copy link
Member

@cquiroz cquiroz commented Mar 18, 2019

The sacala doc for HttpApp has a reference to a G typeparam that no longer exists

Signed-off-by: Carlos Quiroz <carlos.m.quiroz@gmail.com>
@ChristopherDavenport ChristopherDavenport merged commit d7f8c27 into http4s:master Mar 18, 2019
1 check passed
Loading
@cquiroz cquiroz deleted the doc-upd branch Mar 18, 2019
mkows
Copy link
Contributor

mkows commented on 2c42ce1 Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cquiroz shouldn't it persist the info about the effect type of bodies? As F is passed as both.

Loading

cquiroz
Copy link
Member

cquiroz commented on 2c42ce1 Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the comment could be reworded in that sense

Loading

mkows
Copy link
Contributor

mkows commented on 2c42ce1 Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cquiroz addressed in #2478

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants