Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2461 #2466

Merged
merged 2 commits into from Mar 21, 2019
Merged

Fix issue #2461 #2466

merged 2 commits into from Mar 21, 2019

Conversation

@VladKopanev
Copy link
Contributor

@VladKopanev VladKopanev commented Mar 20, 2019

No description provided.

Copy link
Member

@rossabaker rossabaker left a comment

Thanks! Should we deprecate message while we're at it? It doesn't implement anything. It should have just been getMessage all along.

@VladKopanev
Copy link
Contributor Author

@VladKopanev VladKopanev commented Mar 20, 2019

@rossabaker it seems like this method is not used at least in htt4s projects. I don't know if it has been used in any dependent projects outside http4s. Yeah, maybe it's a good idea to have this message deprecated for a while. Will do.

@VladKopanev
Copy link
Contributor Author

@VladKopanev VladKopanev commented Mar 20, 2019

@rossabaker I also want to clarify this before committing: which version should I put in since field of deprecated annotation? Is it going to be a "0.20.0-M7" release?

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Mar 20, 2019

0.20.0 is fine presently.

@rossabaker rossabaker merged commit 80e519f into http4s:master Mar 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants