Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.0 support #2493

Merged
merged 73 commits into from Jun 17, 2019
Merged

Scala 2.13.0 support #2493

merged 73 commits into from Jun 17, 2019

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Apr 6, 2019

A long way from working, but we can start tracking what we need. Many of these are blocked on their own dependencies:

  • better-monadic-for
  • cats
  • cats-effect
  • discipline
  • fs2
  • kind-projector
  • log4s
  • parboiled (our fork)
  • scalacheck
  • specs2
  • vault
@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Apr 9, 2019

parboiled2 blocked on sirthias/parboiled2#200

Loading

@rossabaker rossabaker mentioned this pull request May 2, 2019
@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented May 5, 2019

  • log4s should soon be unblocked by Log4s/log4s#32.
  • parboiled2 is merged and just needs a release when I get home.

The listed dependencies are just core. There are definitely more to come.

Loading

@aeons
Copy link
Member

@aeons aeons commented Jun 13, 2019

I updated sbt-doctest, but that doesn't seem to work. mimedb-generator doesn't work with 2.13, and I'm not 100% on how to force that to 2.12.

Still waiting for boopickle and scalatags to publish for 2.13, they both have merged the necesarry code.

Loading

@aeons
Copy link
Member

@aeons aeons commented Jun 14, 2019

All dependencies are here, except treehugger (for mimedb-generator).

I updated the examples to take Blocker from the end of the world to where it's used.

I updated one cats laws test (EntityEncoderSpec) so that it works after typelevel/cats#2577, but I don't really know how to fix the one in EntityDecoderSpec.

mimedb-generator and doctests are still not working.

Loading

@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Jun 16, 2019

mimedb-generator is made more challenging since the default Scala version changed to 2.13 (which is good), but has to be excluded from 2.13. We could set its default Scala version to 2.12, but that's quirky given that it depends on other http4s modules. I think it might be better if that project were converted to an sbt plugin that didn't depend on http4s. I'll poke at that.

Loading

@aeons
Copy link
Member

@aeons aeons commented Jun 16, 2019

scalatags 0.7.0 is not published for scala 2.11.

Loading

@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Jun 17, 2019

What is the motivation for basing the Blockers on global? This gets people off on the wrong foot. Is this a Travis CI concession?

Loading

@aeons
Copy link
Member

@aeons aeons commented Jun 17, 2019

I was tired and just wanted it to work without thinking. I've improved it now, to the point that it does basically the same as before.
I've mentioned the Resource approach, but not sure if it's stressed enough that that is the preferred way of creating one.

Loading

@aeons aeons marked this pull request as ready for review Jun 17, 2019
@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Jun 17, 2019

I opened the PR so I can't approve it, but 👍

Loading

aeons
aeons approved these changes Jun 17, 2019
@aeons aeons merged commit a221500 into http4s:master Jun 17, 2019
1 check passed
Loading

def withOkHttpClient(okHttpClient: OkHttpClient): OkHttpBuilder[F] =
copy(okHttpClient = okHttpClient)

def withBlock(blocker: Blocker): OkHttpBuilder[F] =
Copy link
Contributor

@fthomas fthomas Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the deprecation warning below refers to withBlocker I guess this method should have been called withBlocker too. Note the missing er.

Loading

Copy link
Member

@aeons aeons Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, that's on me. Good catch.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants