Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise DecodeFailure with MonadError instead of throwing #2506

Merged
merged 1 commit into from Apr 11, 2019

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Apr 11, 2019

Fixes #2504. Similar to #2502.

This code was written before the effect was polymorphic, and relies on now undefined behavior. The MonadError constraint lets us raise the error into F lawfully. Optimization coming in cats is noted. This rippled to the oauth1 client.

@rossabaker rossabaker merged commit 333aae5 into http4s:master Apr 11, 2019
1 check passed
@Fristi
Copy link

@Fristi Fristi commented Apr 12, 2019

Thanks 👍 that's real quick :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants