New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status Methods Which Use String
or URI
#2518
Add status Methods Which Use String
or URI
#2518
Conversation
9de2264
to
2fec6e0
Compare
I don't think the travis failure is related to my change. |
Thanks. I agree on the CI and restarted Travis. Whether we want to do this, or move in the opposite direction, is #2483. We should agree on our strategy there, and then either approve or close this. |
I'm for adding them for consistency now, but us all keeping in mind they may be removed with the other overrides sometime in the future.
If we do these, then also |
It's a lot easier to add methods than take them away, and we have a general aversion to overloads. I think this is a symptom of friction in creating requests. I'd like to think about how we can do better there. I vote we think about this during 0.20, since 0.21 is likely just around the corner. |
@rossabaker any status updates on this? |
I hoped someone would come up with a simpler way of building requests that reduces the desire for overloads, but we haven't seen one yet. I'm usually opposed to overloads, but I guess I'm a mild |
@rossabaker would you prefer |
Yes, I'd be a lot more in favor of that. I'd also make clear that they're GET requests in the scaladoc. |
@rossabaker will do. |
@rossabaker updated. |
These are similar to the `expect` methods which take the same arguments. They are particularly useful for test.
2fec6e0
to
fadaf57
Compare
@rossabaker oops, forgot to push. Updated now. |
These are similar to the
expect
methods which take the same arguments. They are particularly useful for test.