Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize selectorThreadFactory for blaze server #2520

Merged
merged 2 commits into from Apr 20, 2019

Conversation

Projects
None yet
2 participants
@rossabaker
Copy link
Member

commented Apr 19, 2019

Inspired by Twitter conversation with @djspiewak. I'm not changing the default at this stage in the release cycle, but making it possible for Daniel (or others) to get empirical evidence that it's the right thing to do. We can tweak the default in 0.20.1 or later, but this needs to go in now.

Pending release of http4s/blaze#282 before it will compile.

@rossabaker rossabaker marked this pull request as ready for review Apr 20, 2019

@rossabaker

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

Build won't pass if blaze-0.14.0 isn't synced yet, but we can restart.

@rossabaker rossabaker merged commit 83fcf24 into http4s:master Apr 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.