Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSpider: use a point-full implementation. #2525

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
3 participants
@diesalbla
Copy link
Contributor

commented Apr 23, 2019

The previous implementation of noSpider, while functional and point-free, was a bit too difficult to understand, and was making unneeded use of the Kleisli and OptionT wrappers.

An alternative implementation, that uses these wrappers as little as possible, is far more readable.

NoSpider: use a point-ful implementation.
The previous implementation of noSpider, while functional and
point-free, was a bit too difficult to understand, and was making
heavy use of the Kleisli and OptionT wrappers.

An alternative implementation, that uses these wrappers as little as
possible, is more readable and may save some allocations.

@diesalbla diesalbla changed the title NoSpider: use a point-ful implementation. NoSpider: use a point-full implementation. Apr 23, 2019

@jmcardon
Copy link
Member

left a comment

I'm 👍 with this change.

This reads a bit better and allocates one less closure i think.

@rossabaker
Copy link
Member

left a comment

👍 thanks!

@rossabaker rossabaker merged commit cc76edc into http4s:master Apr 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@diesalbla diesalbla deleted the diesalbla:nospider_pointy branch Apr 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.