Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translate extension methods for HttpRoutes and HttpApp #2535

Merged
merged 4 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@bplommer
Copy link
Contributor

commented Apr 29, 2019

Adds imapK extension methods to the Kleisli syntax module to change the effect type of HttpRoutes and HttpApp.

@rossabaker
Copy link
Member

left a comment

Thanks! I like the functionality. I'm a little concerned the imapK name might clash with FunctorK in cats-tagless. As far as I can tell, there is no instance for Kleisli, but maybe that's coming?.

Would imapHttpApp be too weird a name?

@bplommer

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Would imapHttpApp be too weird a name?

It feels a little wordy to me. How about translate, like in fs2 Stream?

@rossabaker

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Yes, I like translate!

@bplommer bplommer changed the title Add imapK extension methods for HttpRoutes and HttpApp Add translate extension methods for HttpRoutes and HttpApp May 3, 2019

@rossabaker

This comment has been minimized.

Copy link
Member

commented May 3, 2019

After all that bincompat work, this could go on 0.20. If it passes CI there, I'll merge there. If it doesn't, I'll switch back and merge to matser.

@rossabaker rossabaker changed the base branch from master to series/0.20 May 3, 2019

@rossabaker

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Ah, no need to rebuild even. 🎉

@rossabaker rossabaker merged commit fdc8434 into http4s:series/0.20 May 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bplommer bplommer deleted the bplommer:imapk-pr branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.