Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Narrow Imports from Cats in Core package #2539
Our contributors' guide speaks a little about imports, but not to these particular issues. We enforce scalafmt, but scalafmt doesn't have a lot to say about imports, which leads to this being one of the more variant areas of style. We could tighten up the recommendations.
@rossabaker I can personally understand the desire to use
The code in the PR is already looking for a compromise: at some point, where there are four or five syntax or instances imports, a
In any case, these changes are doing no harm.
My experience is that these imports don't substantially affect compile time. (Imports in other libraries that derive instances, for sure. These imports, no.) I'd want to see a very striking difference on this project to change my mind. Maintainer time is far more precious than CPU time, and I find narrowing implicit imports to be a chore. And mixing a la carte imports with regular imports has come up a couple times on Gitter recently, and I really don't want to encourage a style that raises the barrier to new contributors, given how uninformative the compilation failures are.
I still like eliminating wild cards on things named in the code.