Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translate method to Client [binary breaking] #2548

Merged
merged 5 commits into from May 28, 2019

Conversation

@bplommer
Copy link
Contributor

commented May 3, 2019

No description provided.

@rossabaker
Copy link
Member

left a comment

Thanks. Good addition. Just a couple consistency questions that I don't immediately have the answer to myself.

client/src/main/scala/org/http4s/client/Client.scala Outdated Show resolved Hide resolved
client/src/main/scala/org/http4s/client/Client.scala Outdated Show resolved Hide resolved

@bplommer bplommer changed the title Add imapK method to Client [binary breaking] Add translate method to Client [binary breaking] May 12, 2019

@rossabaker
Copy link
Member

left a comment

I like it. It just needs test:scalafmt run, and the build should pass.

bplommer added some commits May 16, 2019

@rossabaker
Copy link
Member

left a comment

That test failure is not this. I'm working on restabilizing CI.

@rossabaker rossabaker merged commit bf8aee5 into http4s:master May 28, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@bplommer bplommer deleted the bplommer:client-imapk-pr branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.