Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cats-effect 1.3.0 and remove workarounds introduced in #2470 #2549

Conversation

@RafalSumislawski
Copy link
Contributor

@RafalSumislawski RafalSumislawski commented May 3, 2019

- remove the workarounds for typelevel/cats-effect#487 introduced in http4s#2470 as the issue is fix in cats-effects 1.3.0
@rossabaker
Copy link
Member

@rossabaker rossabaker commented May 3, 2019

This should go into series/0.20 instead of master. master will be cats-2.0 and cats-effect-2.0. But this otherwise looks good. Thank you!

@RafalSumislawski RafalSumislawski changed the base branch from master to series/0.20 May 3, 2019
@rossabaker
Copy link
Member

@rossabaker rossabaker commented May 3, 2019

Just needs a test:scalafmt and the build should pass.

Copy link
Member

@rossabaker rossabaker left a comment

👍 on green

@aeons aeons merged commit d255759 into http4s:series/0.20 May 4, 2019
1 check passed
@@ -178,7 +178,7 @@ class ClientTimeoutSpec extends Http4sSpec {
// if the requestTimeout is hit then it's a TimeoutException
// if establishing connection fails first then it's an IOException

// The expected behaviour is that the requestTimeout will happen first, but fetchAs will additionally wait for the IO.sleep(2.seconds) to complete.
// The expected behaviour is that the requestTimeout will happen first, but fetchAs will additionally wait for the IO.sleep(1000.millis) to complete.
Copy link
Contributor

@kevinmeredith kevinmeredith May 6, 2019

So the requestTimeout isn't actually respected, i.e. given that c.fetchAs[String](FooRequest).unsafeRunTimed(1500.millis) fails after 1000 ms, not 50 ms, @RafalSumislawski?

Copy link
Contributor

@kevinmeredith kevinmeredith May 6, 2019

An acquire operation of cats' Bracket/Resource is uncancelable

is the answer to my question, per #2386 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants