Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityDecoder_combineK unify cases. #2563

Merged
merged 1 commit into from May 15, 2019

Conversation

@diesalbla
Copy link
Contributor

commented May 9, 2019

Simplifies the code of the combineK function, from the instance of
SemigroupK for EntityDecoder. Before there were two cases, based
on an Option, that were very similar.

EntityDecoder_combineK unify cases.
Simplifies the code of the `combineK` function, from the instance of
`SemigroupK` for `EntityDecoder`. Before there were two cases, based
on an `Option`, that were very similar.
@aeons

aeons approved these changes May 9, 2019

@rossabaker
Copy link
Member

left a comment

👍 This is a nice cleanup.

@rossabaker rossabaker merged commit 4263709 into http4s:master May 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@diesalbla diesalbla deleted the diesalbla:entityDecoder_combineK_unify branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.