Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AuthedService, replace it with AuthedRoutes with updated API #2567

Merged
merged 8 commits into from Jun 6, 2019

Conversation

@bplommer
Copy link
Member

@bplommer bplommer commented May 12, 2019

  • Add of and apply methods to AuthedService companion that are consistent with those for HttpRoutes
  • Add mapK to AuthedRequest
  • Add mapK extension method for AuthedService

AuthedService seems to have fallen behind HttpRoutes - perhaps it's worth a breaking PR to rename it to AuthedRoutes and change the order of the type params?

EDIT: The overloaded apply method on AuthedService caused a bunch of things to break. I've renamed the new one to apply_ for now, but I'm not very happy with that name - thoughts?

@rossabaker
Copy link
Member

@rossabaker rossabaker commented May 15, 2019

Thanks, I like this. The build failure is a flake.

The order of the type parameters on AuthedService are weird because of #1506. Does this reasoning no longer hold?

If we deprecate the AuthedService alias in favor of AuthedRoutes, and deprecate the AuthedService companion object in favor of a new AuthedRoutes one, we could do this in a binary compatible way, get the apply syntax back, and not have the awkward apply_ method name. What do you think?

Loading

@bplommer
Copy link
Member Author

@bplommer bplommer commented May 16, 2019

Good point about deprecating AuthedService - I'll update the PR with AuthedRoutes. I'll also fix the type parameter orders.

Loading

@bplommer bplommer changed the title Improve AuthedService and AuthedRequest functionality Deprecate AuthedService, replace it with AuthedRoutes with updated API May 26, 2019
Copy link
Member

@rossabaker rossabaker left a comment

Apologies for the slow followup. This looks great.

Loading

@aeons aeons merged commit 6bd0732 into http4s:series/0.20 Jun 6, 2019
1 check passed
Loading
@bplommer bplommer deleted the authedservice-translate-pr branch Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants