Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release steps agree with Travis stages #2575

Merged
merged 1 commit into from May 16, 2019

Conversation

@rossabaker
Copy link
Member

commented May 16, 2019

No description provided.

case Some("master") => true
case Some(branch) if branch.startsWith("series/") => true
case _ => false
})

This comment has been minimized.

Copy link
@rossabaker

rossabaker May 16, 2019

Author Member

The old TRAVIS_BRANCH check is covered by .travis.yml. The old oraclejdk8 reference is why #2570 failed to publish, and is also adequately covered by .travis.yml.

},
http4sMasterBranch := sys.env.get("TRAVIS_BRANCH").contains("master"),

This comment has been minimized.

Copy link
@rossabaker

rossabaker May 16, 2019

Author Member

This was only used to determine whether we publish the site. That has been moved to .travis.yml.

@@ -37,22 +35,15 @@ object Http4sPlugin extends AutoPlugin {
// Many steps only run on one build. We distinguish the primary build from
// secondary builds by the Travis build number.
isTravisBuild := sys.env.get("TRAVIS").isDefined,
http4sPrimary := sys.env.get("TRAVIS_JOB_NUMBER").fold(true)(_.endsWith(".1")),

This comment has been minimized.

Copy link
@rossabaker

rossabaker May 16, 2019

Author Member

This has been ever since we introduced stages, and why we've had to manually tag and bump the last few releases. It's obsolete.

@rossabaker rossabaker changed the base branch from master to series/0.20 May 16, 2019

@rossabaker rossabaker merged commit d584fd4 into http4s:series/0.20 May 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rossabaker rossabaker deleted the rossabaker:release-steps branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.