Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestLogger: drying up some code #2580

Merged
merged 1 commit into from May 20, 2019

Conversation

@diesalbla
Copy link
Contributor

commented May 18, 2019

The operation to log the request was repeated three times, so we
extract it as a def. Also, folds two cases in the guaranteeCase.

RequestLogger: drying up some code
The operation to log the request was repeated three times, so we
extract it as a `def`. Also, folds two cases in the `guaranteeCase`.
@rossabaker
Copy link
Member

left a comment

Thanks!

@aeons aeons merged commit 53bcad0 into http4s:master May 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@diesalbla diesalbla deleted the diesalbla:requestlogger_reduceCode branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.