Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default head no inner kleisli #2582

Merged
merged 1 commit into from May 21, 2019

Conversation

@diesalbla
Copy link
Contributor

commented May 19, 2019

Removes the use and allocation of extra Kleisli in the private method.
Avoids use of instance MonoidK[F] => MonoidK[Kleisli[F, A, B]

@diesalbla diesalbla force-pushed the diesalbla:DefaultHead_no_inner_Kleisli branch from 1e74c39 to 50400c9 May 21, 2019

@diesalbla diesalbla marked this pull request as ready for review May 21, 2019

@rossabaker

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Trivial conflict to resolve and it's ready.

DefaultHead: simplify inner Kleisli.
Removes the use and allocation of extra Kleisli in the private method.
Avoids use of instance `MonoidK[F] => MonoidK[Kleisli[F, A, B]`

@diesalbla diesalbla force-pushed the diesalbla:DefaultHead_no_inner_Kleisli branch from 2d0525b to 73dfda6 May 21, 2019

@rossabaker rossabaker merged commit 105a7f5 into http4s:master May 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@diesalbla diesalbla deleted the diesalbla:DefaultHead_no_inner_Kleisli branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.