Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using literall interpolators triggers Wartremover error #2591

Merged
merged 1 commit into from May 22, 2019

Conversation

perok
Copy link
Contributor

@perok perok commented May 21, 2019

Change literal interpolator macros to use unsafe methods to avoid
triggering Wartremover EitherProjectionPartial warning.

Change string interpolator macros to use unsafe methods to avoid
triggering Wartremover EitherProjectionPartial warning.
@perok perok changed the title Using string interpolators triggers Wartremover error Using literall interpolators triggers Wartremover error May 21, 2019
Copy link
Member

@rossabaker rossabaker left a comment

I've never felt particularly good about these partial methods, but we do mark them unsafe.

@aeons aeons merged commit bc5b8f3 into http4s:master May 22, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants