Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized empty list methods and Removed reduntant braces #2596

Merged
merged 1 commit into from May 26, 2019

Conversation

@ayushhooda
Copy link
Contributor

@ayushhooda ayushhooda commented May 26, 2019

Filename: MimeGenerator.scala
Action Items:

  1. Removed redundant braces.
  2. Replaced List[String].lift(0).getOrElse("") with List[String].headOption.getOrElse("").
  3. Replaced List[String].length > 0 with List[String].nonEmpty.
Copy link
Contributor

@diesalbla diesalbla left a comment

I think you meant redundant parentheses.

Loading

Copy link
Member

@cquiroz cquiroz left a comment

Thanks, LGTM

Loading

@aeons aeons merged commit eb9b084 into http4s:master May 26, 2019
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants