Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced Uri.uri(...) with uri(...) in tuts docs Issue 2603 #2608

Merged
merged 2 commits into from Jun 2, 2019

Conversation

@mcintdan
Copy link
Contributor

commented May 29, 2019

Does this look better for Issue #2603 ? I am sorry if I am creating more work for you, genuinely trying to help, but I do not have a lot of experience with sbt. If this isn't correct, please kindly let me know if you want me to take a step back so someone else with more sbt experience can address the issue. Otherwise, I will take a couple of days to practice and test this out before submitting another PR. Also I am not sure if I needed to actually close the previous PR and create a new one, hope what I did was okay. Thanks for your patience and appreciate all your feedback. :-)

@rossabaker
Copy link
Member

left a comment

Nope, this is much appreciated. 👍 if it passes Travis. I think it will. If not, we'll take another look.

@mcintdan

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

Awesome, I am so happy it looks okay! Thanks and I look forward to contributing more to this project as I gain experience with http4s.

@yoohaemin

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

I have a small suggestion since this isn't merged yet: adding where to find the imports for the interpolator. I recall it took me some time to find the correct imports during migration from Uri.uri to uri"".

Later when I found out, I was a bit surprised that the required import was not org.http4s.syntax.all._ nor org.http4s.implicits._ (which is the same thing), but org.http4s._. I think it could be worth a small mention in the docs, on where you can find the implicits for the interpolator, like

If you have a literal string, you can use uri"...", which was imported via import org.http4s._:

let me know if you have any better suggestions :)

@rossabaker

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

I wondered about having these string contexts on org.http4s.implicits._ when they were added and didn't get generate much discussion either way. My gut feeling is that's where they belong. I'm going to spin that off as a separate issue.

@rossabaker rossabaker merged commit d13e0c9 into http4s:master Jun 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.